Bump OTel 1.4.0-beta.3 #1647
Merged
Bump OTel 1.4.0-beta.3 #1647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and other released to the newest versions
…aries list After upgrade all places references 7.0.0
it is needed by .NET 6 applications
as we should always bring the newest packages
Workaround will be fixed in scope of #1646 Co-authored-by: Paulo Janotti <[email protected]> Co-authored-by: Rasmus Kuusmann <[email protected]>
from documentation. It was removed from instrumentation package
Kielek
commented
Nov 23, 2022
|
So far... LGTM 👍 |
| <PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="6.0.2" /> | ||
| <PackageReference Include="Microsoft.Extensions.Logging.Configuration" Version="6.0.0" /> | ||
| <PackageReference Include="System.Diagnostics.DiagnosticSource" Version="7.0.0" /> | ||
| <PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="7.0.0" /> |
There was a problem hiding this comment.
Does 6.0 app fail to instrument, if below 3 packages are not present?
There was a problem hiding this comment.
Most of the SmokeTests are failing in the similar way when I have removed
--- a/src/OpenTelemetry.AutoInstrumentation.AdditionalDeps/Directory.Build.props
+++ b/src/OpenTelemetry.AutoInstrumentation.AdditionalDeps/Directory.Build.props
@@ -1,9 +1,6 @@
<Project>
<ItemGroup>
<PackageReference Include="System.Diagnostics.DiagnosticSource" Version="7.0.0" />
- <PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="7.0.0" />
- <PackageReference Include="Microsoft.Extensions.Logging.Configuration" Version="7.0.0" />
- <PackageReference Include="Microsoft.Extensions.Configuration.EnvironmentVariables" Version="7.0.0" />
<PackageReference Include="MongoDB.Driver.Core.Extensions.DiagnosticSources" Version="1.3.0" />
</ItemGroup>
</Project>Unhandled exception. System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation.
---> System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation.
---> System.TypeInitializationException: The type initializer for 'OpenTelemetry.AutoInstrumentation.Loader.Startup' threw an exception.
---> System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation.
---> System.IO.FileNotFoundException: Could not load file or assembly 'Microsoft.Extensions.Configuration.Abstractions, Version=3.1.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60'. The system cannot find the file specified.
File name: 'Microsoft.Extensions.Configuration.Abstractions, Version=3.1.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60'
at Microsoft.Extensions.DependencyInjection.ProviderBuilderServiceCollectionExtensions.AddOpenTelemetryTracerProviderBuilderServices(IServiceCollection services)
at OpenTelemetry.Trace.TracerProviderBuilderBase..ctor()
at OpenTelemetry.Trace.TracerProviderBuilderSdk..ctor()
at OpenTelemetry.Sdk.CreateTracerProviderBuilder()
at OpenTelemetry.AutoInstrumentation.Instrumentation.Initialize() in C:\GitHub\opentelemetry-dotnet-instrumentation\src\OpenTelemetry.AutoInstrumentation\Instrumentation.cs:line 119
--- End of inner exception stack trace ---
at System.RuntimeMethodHandle.InvokeMethod(Object target, Span`1& arguments, Signature sig, Boolean constructor, Boolean wrapExceptions)
at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
at System.Reflection.MethodBase.Invoke(Object obj, Object[] parameters)
at OpenTelemetry.AutoInstrumentation.Loader.Startup.TryLoadManagedAssembly() in C:\GitHub\opentelemetry-dotnet-instrumentation\src\OpenTelemetry.AutoInstrumentation.Loader\Startup.cs:line 71
at OpenTelemetry.AutoInstrumentation.Loader.Startup..cctor() in C:\GitHub\opentelemetry-dotnet-instrumentation\src\OpenTelemetry.AutoInstrumentation.Loader\Startup.cs:line 47
--- End of inner exception stack trace ---
at OpenTelemetry.AutoInstrumentation.Loader.Startup..ctor()
at System.RuntimeType.CreateInstanceDefaultCtor(Boolean publicOnly, Boolean wrapExceptions)
--- End of inner exception stack trace ---
at System.RuntimeType.CreateInstanceDefaultCtor(Boolean publicOnly, Boolean wrapExceptions)
at System.Activator.CreateInstance(Type type, Boolean nonPublic, Boolean wrapExceptions)
at System.RuntimeType.CreateInstanceImpl(BindingFlags bindingAttr, Binder binder, Object[] args, CultureInfo culture)
at System.Activator.CreateInstance(Type type, BindingFlags bindingAttr, Binder binder, Object[] args, CultureInfo culture, Object[] activationAttributes)
at System.Reflection.Assembly.CreateInstance(String typeName, Boolean ignoreCase, BindingFlags bindingAttr, Binder binder, Object[] args, CultureInfo culture, Object[] activationAttributes)
at System.Reflection.Assembly.CreateInstance(String typeName)
at StartupHook.Initialize() in C:\GitHub\opentelemetry-dotnet-instrumentation\src\OpenTelemetry.AutoInstrumentation.StartupHook\StartupHook.cs:line 58
--- End of inner exception stack trace ---
at System.RuntimeMethodHandle.InvokeMethod(Object target, Span`1& arguments, Signature sig, Boolean constructor, Boolean wrapExceptions)
at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
at System.StartupHookProvider.CallStartupHook(StartupHookNameOrPath startupHook)
at System.StartupHookProvider.ProcessStartupHooks()
| @@ -5,7 +5,7 @@ | |||
| </PropertyGroup> | |||
|
|
|||
| <ItemGroup> | |||
| <PackageReference Include="System.Diagnostics.DiagnosticSource" Version="6.0.0" /> | |||
| <PackageReference Include="System.Diagnostics.DiagnosticSource" Version="7.0.0" /> | |||
There was a problem hiding this comment.
I understand this reference existed earlier. Should AdditionalDeps help in case of net6.0/7.0?
There was a problem hiding this comment.
Good catch. It is not needed. There is no usage of this in the test application.
Removed reference: b906557
|
@Kielek Overall it looks good to me, left few comments related to AddtionalDeps package and usage in app. |
we expect that it will be needed shortly
It is not used in the application, so it is loaded from additional store
pellared
approved these changes
Nov 24, 2022
|
I think that the versions in |
|
@pellared, documentation updated, together with changelog. |
pellared
approved these changes
Nov 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Fixes #1538
Fixes #1021
What
Bump OTel 1.4.0
Tests
CI.
Checklist
CHANGELOG.mdis updated.TODO
OpenTelemetry.Instrumentation.Runtimepackage to fix failing test on our side - [Instrumentation.Runtime] Release 1.1.0-beta.1 opentelemetry-dotnet-contrib#786 (comment)Potentially wait for stable OTel 1.4.0 before mergeNotes
Do not merge until 0.5.0 is released.